Re: [PATCH 1/1] subtree: add build targets 'man' and 'html'
From: Johannes Schindelin <hidden>
Date: 2018-10-12 08:08:19
Possibly related (same subject, not in this thread)
- 2018-10-16 · Re: [PATCH 1/1] subtree: add build targets 'man' and 'html' · Junio C Hamano <hidden>
- 2018-10-16 · Re: [PATCH 1/1] subtree: add build targets 'man' and 'html' · Junio C Hamano <hidden>
- 2018-10-07 · [PATCH 1/1] subtree: add build targets 'man' and 'html' · Christian Hesse <hidden>
On Wed, 10 Oct 2018, Junio C Hamano wrote:
Christian Hesse [off-list ref] writes:quoted
From: Christian Hesse <redacted> We have targets 'install-man' and 'install-html', let's add build targets as well. ... +man: $(GIT_SUBTREE_DOC) + +html: $(GIT_SUBTREE_HTML) +As 'contrib' material without real maintenance, I do not care too deeply, but shouldn't this change be more like this to avoid duplicating the list of targets?
Ævar mentioned that he'd like this to graduate from contrib into core, and I had briefly looked at making subtree a built-in to that end. IOW please do not get too used to subtree being in contrib. Ciao, Dscho
quoted hunk ↗ jump to hunk
diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile index 5c6cc4ab2c..4a10a020a0 100644 --- a/contrib/subtree/Makefile +++ b/contrib/subtree/Makefile@@ -59,17 +59,21 @@ $(GIT_SUBTREE): $(GIT_SUBTREE_SH) doc: $(GIT_SUBTREE_DOC) $(GIT_SUBTREE_HTML) +man: $(GIT_SUBTREE_DOC) + +html: $(GIT_SUBTREE_HTML) + install: $(GIT_SUBTREE) $(INSTALL) -d -m 755 $(DESTDIR)$(gitexecdir) $(INSTALL) -m 755 $(GIT_SUBTREE) $(DESTDIR)$(gitexecdir) install-doc: install-man install-html -install-man: $(GIT_SUBTREE_DOC) +install-man: man $(INSTALL) -d -m 755 $(DESTDIR)$(man1dir) $(INSTALL) -m 644 $^ $(DESTDIR)$(man1dir) -install-html: $(GIT_SUBTREE_HTML) +install-html: html $(INSTALL) -d -m 755 $(DESTDIR)$(htmldir) $(INSTALL) -m 644 $^ $(DESTDIR)$(htmldir)@@ -94,4 +98,4 @@ clean: $(RM) $(GIT_SUBTREE) $(RM) *.xml *.html *.1 -.PHONY: FORCE +.PHONY: FORCE man html install-man install-html