Thread (1 message) 1 message, 1 author, 2018-10-12

Re: [PATCH v4 0/3] alias help tweaks

From: Junio C Hamano <hidden>
Date: 2018-10-12 03:17:42

Rasmus Villemoes [off-list ref] writes:
v2: Added patches 2 and 3, made "git cmd --help" unconditionally (no
config option, no delay) redirect to the aliased command's help,
preserve pre-existing behaviour of the spelling "git help cmd".

v3: Add some additional comments in patch 1 and avoid triggering leak
checker reports. Use better wording in patch 3.

v4: Reword commit log in patch 1.
Sorry for failing to point it out and let the style carried over to
v4, but the above is insufficient for a cover latter.  Those who
missed an earlier round has no clue what these patches are about,
and there is not even a pointer to find an earlier discussion in the
list archive.

I think the patches are good with the rounds of reviews it went
through, so let's merge it to 'next'.  Here is what I plan to start
the merge message of the series:

     "git cmd --help" when "cmd" is aliased used to only say "cmd is
     aliased to ...".  Now it shows that to the standard error stream
     and runs "git $cmd --help" where $cmd is the first word of the
     alias expansion.

Please do the cover-letter better next time.

Thanks.
Rasmus Villemoes (3):
  help: redirect to aliased commands for "git cmd --help"
  git.c: handle_alias: prepend alias info when first argument is -h
  git-help.txt: document "git help cmd" vs "git cmd --help" for aliases

 Documentation/git-help.txt |  4 ++++
 builtin/help.c             | 34 +++++++++++++++++++++++++++++++---
 git.c                      |  3 +++
 3 files changed, 38 insertions(+), 3 deletions(-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help