Re: [PATCH 2/3] ls-remote: release memory instead of UNLEAK
From: Junio C Hamano <hidden>
Date: 2018-10-11 01:20:17
Olga Telezhnaya [off-list ref] writes:
Use ref_array_clear() to release memory instead of UNLEAK macros. Signed-off-by: Olga Telezhnaia <redacted> --- builtin/ls-remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
OK, this is immediately before the command exits, and we have a way to clear and release the resource, so it is obvious we should use it. Good.
quoted hunk
diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c index 1a25df7ee15b4..6a0cdec30d2d7 100644 --- a/builtin/ls-remote.c +++ b/builtin/ls-remote.c@@ -151,6 +151,6 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix) } UNLEAK(sorting); - UNLEAK(ref_array); + ref_array_clear(&ref_array); return status; } --https://github.com/git/git/pull/538