Re: [PATCH 1/1] rebase -i: introduce the 'break' command
From: Junio C Hamano <hidden>
Date: 2018-10-09 03:59:42
Johannes Schindelin [off-list ref] writes:
Hi Junio, On Fri, 5 Oct 2018, Junio C Hamano wrote:quoted
"Johannes Schindelin via GitGitGadget" [off-list ref] writes:quoted
From: Johannes Schindelin <redacted> The 'edit' command can be used to cherry-pick a commit and then immediately drop out of the interactive rebase, with exit code 0, to let the user amend the commit, or test it, or look around.... If one wants to emulate this with the versions of Git that are currently deployed, would it be sufficient to insert "exec false" instead of "break"?There is one crucial difference: the exit code.
OK, and it was good that you explicitly said "with exit code 0" in the log message. Together with the idea to update the doc I floated earlier, this probably is worth documenting, too.
quoted
I think the earlier request asked for 'pause' (I didn't dig the list archive very carefully, though),No need to: I mentioned it in the cover letter. Here is the link again, for your convenience: https://public-inbox.org/git/20180118183618.39853-3-sbeller@google.com/
No, you misunderstood. I knew what message in the immediate past triggered this patch and that wasn't what I "could have dug for but didn't". "The earlier request" I meant was another one I recall that was made long time ago---that was what I "could have dug for but didn't".
Good initial version. I would like it to be a bit more precise about who exits with what status. How about this:
Sounds good. It is likely that I'll either forget or will continue to be too busy to pick textual pieces and assemble together myself, so I'll leave it as a left over bit for somebody reading from the sideline to send in a finished version if they care deeply enough ;-) Thanks.