Thread (1 message) 1 message, 1 author, 2018-09-21

Re: [RFC PATCH v4 1/3] Add support for nested aliases

From: Junio C Hamano <hidden>
Date: 2018-09-21 15:59:17

Tim Schumacher [off-list ref] writes:
it is located at the top of the while() loop. Giving an example is nice, but wouldn't
it be better to say something like the following?

	/*
	 * Check if av[0] is a command before seeing if it is an
	 * alias to avoid taking over existing commands
	 */
If we have more concrete and constructive things to explain why we
choose to forbid it, that may be worth saying, but I agree that it
does not add much value to this comment to declare that an attempt
to take over existing commands is "insane".

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help