Thread (1 message) 1 message, 1 author, 2018-09-20

Re: [PATCH 1/9] Makefile: add a hdr-check target

From: Junio C Hamano <hidden>
Date: 2018-09-20 18:49:55

Ramsay Jones [off-list ref] writes:
Yes, this was one of my first concerns (I even asked Elijah what
compiler options he used), but I was getting useful results without
passing CFLAGS, so I just ignored that issue ... :-D
...
Indeed. This bothered me as well. The 'compat' directory does not
follow the 'usual pattern' of the main headers and is particularly
sensitive to the lack of various -DMACROs. I had initially included
_all_ sub-directories in the 'exclude list' (to follow what Elijah
had done), but then removed one at a time ...

I am open to suggestions for improvements. ;-)
Perhaps it is sufficient to add a mention of these two issues in log
message and an in-code comment nearby the .hco rule in Makefile, so
that people can come back later to discover what design choice we
made (i.e. "without worrying about these two issues, we are getting
useful enough results, so we decided it is OK at least for now not
to worry about them").

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help