Thread (1 message) 1 message, 1 author, 2018-09-17

Re: [PATCH v4 05/23] blame.c: rename "repo" argument to "r"

From: Junio C Hamano <hidden>
Date: 2018-09-17 16:32:56

Nguyễn Thái Ngọc Duy  [off-list ref] writes:
The current naming convention for 'struct repository *' is 'r' for
temporary variables or arguments. I did not notice this. Since we're
updating blame.c again in the next patch, let's fix this.
It is likely that we end up having to refer to an in-core repository
object in many places, so giving a short-and-sweet 'r' to it makes
quite a lot of sense.  One thing we may want to do as preparation
related to this effort is to sweep the codebase to make sure we do
not use 'r' as a variable that refers to anything other than an
in-core repository object.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help