Thread (2 messages) flat view 2 messages, 2 authors, 2018-09-14

Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name

From: Junio C Hamano <hidden>
Date: 2018-09-13 21:52:01

Shulhan [off-list ref] writes:
When adding new remote name with empty string, git will print the
following error message,

  fatal: '' is not a valid remote name\n

But when removing remote name with empty string as input, git shows the
empty string without quote,

  fatal: No such remote: \n

To make these error messages consistent, quote the name of the remote
that we tried and failed to find.

Signed-off-by: Shulhan <redacted>
Reviewed-by: Junio C Hamano <redacted>
---
 builtin/remote.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Have you run "make test" with this change?  

I expect at least 5505.10 to fail without adjustment.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help