Re: [PATCH v3] Allow aliases that include other aliases

On Thu, Sep 06, 2018 at 09:05:50PM +0200, Tim Schumacher wrote:

On 06.09.18 16:57, Jeff King wrote:

quoted

On Thu, Sep 06, 2018 at 04:01:39PM +0200, Ævar Arnfjörð Bjarmason wrote:

quoted

If we don't have some test for these sort of aliasing loops that fails
now, we really should add that in a 1/2 and fix it in this patch in 2/2.

Yes, I'd agree that this is worth adding a test (especially if the
output routines get more complex).

I'll try to come up with a few tests (or one at this point, as we only have
a solution for internal aliases so far) and put them as 1/2. However, I don't know
what file I should put those tests into. t0001-init and t1300-config both seem
to test aliases, but I'm unsure if the new tests should go into one of those
files or a completely new one that is dedicated to aliases.

Yeah, I don't think there's a good place right now. It probably make
sense to start a new one (t0014-alias, maybe? This seems like a basic
functionality that should come early in the suite).

-Peff