Thread (70 messages) 70 messages, 6 authors, 2018-08-22

Re: [PATCH] t6018-rev-list-glob: fix 'empty stdin' test

flat view

From: Eric Sunshine <hidden>
Date: 2018-08-22 20:31:11

On Wed, Aug 22, 2018 at 2:59 PM SZEDER Gábor [off-list ref] wrote:
On Wed, Aug 22, 2018 at 7:53 PM Eric Sunshine [off-list ref] wrote:
quoted
Can you say a word or two (here in the email thread) about how you're
finding these failures (across the various test fixes you've posted
recently)? Are you instrumenting the code in some fashion? Or, finding
them by visual inspection?
Errors from system commands in our tests look like these:
  grep: file3: No such file or directory
i.e. lines starting with various system commands' or test scripts'
names, followed by ': '.

So I've modified t/Makefile to not remove the 'test-results' directory
after a successful 'make test':
And then scanned the results of a '--verbose-log -x' test run with:
  grep -E [...]
and then, for lack of something better to do ;), I started looking at
the simpler looking errors.
Thanks for the explanation. That makes a lot of sense.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help