Re: [PATCH] test-tool.h: include git-compat-util.h
From: Junio C Hamano <hidden>
Date: 2018-08-21 19:03:43
Jeff King [off-list ref] writes:
The test-tool programs include "test-tool.h" as their first include, which breaks our CodingGuideline of "the first include must be git-compat-util.h or an equivalent". Rather than change them all, let's instead make test-tool.h one of those equivalents, just like we do for builtin.h (which many of the actual git builtins include first). Signed-off-by: Jeff King <redacted> --- Repost, as the original was in a larger thread about includes and didn't get any comment.
Thanks. Will queue.
quoted hunk
t/helper/test-tool.h | 2 ++ 1 file changed, 2 insertions(+)diff --git a/t/helper/test-tool.h b/t/helper/test-tool.h index e926c416ea..e954e8c522 100644 --- a/t/helper/test-tool.h +++ b/t/helper/test-tool.h@@ -1,6 +1,8 @@ #ifndef __TEST_TOOL_H__ #define __TEST_TOOL_H__ +#include "git-compat-util.h" + int cmd__chmtime(int argc, const char **argv); int cmd__config(int argc, const char **argv); int cmd__ctype(int argc, const char **argv);