Thread (23 messages) flat view 23 messages, 4 authors, 2018-09-07

Re: Antw: Re: non-smooth progress indication for git fsck and git gc

From: Duy Nguyen <hidden>
Date: 2018-08-21 15:22:00

On Tue, Aug 21, 2018 at 3:13 AM Jeff King [off-list ref] wrote:
I _think_ they should work together OK without further modification.
Once upon a time the caller had to say "don't show if we're past N%
after M seconds", but I think with the current code we'd just show it if
we're not completely finished after 2 seconds.

So it really should just be a simple:

  progress = start_delayed_progress("Hashing packfile", 0);

That said, counting bytes would probably be ugly (just because the
numbers get really big). We'd probably prefer to show a throughput or
something.
Or just an ascii throbber. I think the important thing is communicate
"I'm still doing something, not hanging up". "Hashing packfile"
satisfies the "something" part, the throbber the "hanging".
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help