Re: [PATCH v5 0/7] Speed up unpack_trees()

On Sun, Aug 19, 2018 at 12:01 AM Elijah Newren [off-list ref] wrote:

On Sat, Aug 18, 2018 at 7:41 AM Nguyễn Thái Ngọc Duy [off-list ref] wrote:

quoted

v5 fixes some minor comments from round 4 and a big mistake in 5/5.
Junio's scary feeling turns out true. There is a missing invalidation
in keep_entry() which is not added in 6/7. 7/7 makes sure that similar

I'm having trouble parsing this.  Did you mean "...which is now
added..."?

Oops. Yes.

 Also, if 6/7 represents a fix to the "big mistake in 5/5",
why is 6/7 separate from 5/7 instead of squashed in?

I felt that was cramming up too much in the commit message. But if
it's the right thing to do, I'll reroll and combine 5/7 and 6/7 .
-- 
Duy