Re: [PATCH 2/2] submodule: munge paths to submodule git directories
From: Brandon Williams <hidden>
Date: 2018-08-16 17:34:17
On 08/15, Jonathan Nieder wrote:
Stefan Beller wrote:quoted
Jonathan Nieder wrote:quoted
quoted
All at the cost of recording a little configuration somewhere. If we want to decrease the configuration, we can avoid recording it there in the easy cases (e.g. when name == gitdirname). That's "just" an optimization.Sounds good, but gerrit for example would not take advantage of such optimisation as they have slashes in their submodules. :-( I wonder if we can optimize further and keep slashes if there is no conflict (as then name == gitdirname, so it can be optimized).One possibility would be to treat gsub("/", "%2f") as another of the easy cases. [...]quoted
quoted
And then we have the ability later to handle all the edge cases we haven't handled yet today: - sharding when the number of submodules is too large - case-insensitive filesystems - path name length limits - different sets of filesystem-special characters Sane?
Seems like a sensible thing to do. Let me work up some patches to implement this using config primarily and these other schemes as fallbacks.
quoted
I'll keep thinking about it.Thanks.quoted
FYI: the reduction in configuration was just sent out.https://public-inbox.org/git/20180816023100.161626-1-sbeller@google.com/ for those following along. Ciao, Jonathan
-- Brandon Williams