Re: [RFC PATCH 0/7] Unset the submodule URL in the superproject when no longer needed

On Thu, Aug 16, 2018 at 8:12 AM Junio C Hamano [off-list ref] wrote:

Stefan Beller [off-list ref] writes:

quoted

  Originally we have had the url in the config, (a) that we can change
  the URLs after the "git submodule init" and "git submodule update"
  step that actually clones the submodule if not present and much more
  importantly (b) to know which submodule "was initialized/active".

  Now that we have the submodule.active or even
  submodule.<name>.active flags, we do not need (b) any more.

Up to that point the description is sane.

quoted

  So the URL turns into a useless piece of cruft that just is unneeded
  and might confuse the user.

Opinions?

You spelled out why you do not need for (b) but not for (a) and
worse it is is unclear if you never need it for (a) or under what
condition you need it for (a).  So there isn't enough information to
form an opinion in the above.  Sorry--readers need to go to the real
patches.

Regarding (a): Once the submodule is cloned, you either need
to change the remote in the submodule or you can use "git submodule sync"
which can bypass the superproject config, too (that copies the URL from
.gitmodules to the submodules config/remote)

I don't think (a) is needed after the clone of a submodule is done.