Thread (9 messages) flat view 9 messages, 4 authors, 2018-08-20

Re: "less -F" is broken

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2018-08-15 21:57:19

On Wed, Aug 15, 2018 at 2:29 PM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:
Downloading & trying versions of it locally reveals that it's as of
version 520, not 530. The last version before 520 is 487. Presumably
it's covered by this item in the changelog:

    Don't output terminal init sequence if using -F and file fits on one
    screen[1]
Side note: that's sad, because we already use X in the default exactly
for that reason.

So apparently "less" was broken for us to fix something that we
already had long solved. The code basically tried to do "automatic X
when F is set".

And all that line_count stuff (which is what breaks) is pointless when
-X is already given.

That does give a possible fix: just stop doing the line_count thing if
no_init is set.

So "-F" would continue to be broken, but "-FX" would work.

Something like the attached patch, perhaps?

            Linus

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help