Thread (3 messages) flat view 3 messages, 2 authors, 2018-08-15

Re: [PATCH 1/1] chainlint: fix for core.autocrlf=true

From: Eric Sunshine <hidden>
Date: 2018-08-15 16:32:29

On Wed, Aug 15, 2018 at 10:33 AM Johannes Schindelin via GitGitGadget
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
The `chainlint` target compares actual output to expected output, where
the actual output is generated from files that are specifically checked
out with LF-only line endings. So the expected output needs to be
checked out with LF-only line endings, too.

Signed-off-by: Johannes Schindelin <redacted>
---
diff --git a/t/.gitattributes b/t/.gitattributes
@@ -1,4 +1,5 @@
+/chainlint/*.expect eol=lf
Make sense. I did touch t/.gitignore for the chainlint series but
never thought to examine t/.gitattributes (and wasn't necessarily
aware of its existence). Had I looked inside .gitattributes, perhaps I
would have intuited the need for this change. Thanks for handling it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help