Thread (25 messages) 25 messages, 2 authors, 2018-08-23

Re: [PATCH 4/4] range-diff: indent special lines as context

flat view

From: Stefan Beller <hidden>
Date: 2018-08-13 18:36:34

quoted
The later lines that indicate a change to the Makefile will be treated as
context both in the outer and inner diff, such that those lines stay
regular color.
While I am a fan of having those lines colored correctly, I have to admit
that I am not exactly enthusiastic about that extra indentation...

Otherwise, this looks good to me.
Can you explain what makes you less enthused about the indentation?

Advantage:
* allows easy coloring (easy implementation)
Disadvantage:
* formats change, but the range diff is still in its early design phase,
  so we're not breaking things, yet?
  (Do we ever plan on sending range-diff patches that can be applied to
   rewrite history? I am very uncertain on such a feature request.
   It sounds cool, though)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help