Re: [PATCH 0/4] t5552: fix flakiness by introducing proper locking for GIT_TRACE

Hi Peff,

On Fri, 10 Aug 2018, Jeff King wrote:

On Fri, Aug 10, 2018 at 06:43:07PM +0200, Johannes Schindelin wrote:

quoted

So unless you are willing to ignore, to willfully keep this breakage,
I would suggest not to introduce the ugliness of an overridden
upload-pack for the sole purpose of disabling the tracing on one side,
but instead to get this here bug fixed, by helping me with this here
patch series.

I'm OK if you want to live with the broken test in the interim.

I realize that I failed to tell you that I basically spent 2.5 days worth
of worktime to figure this out and come up with three iterations of the
patch series (you only saw the latest).

I want this patch series in git.git, maybe not in the current form, but in
one form or another. I don't want to spend any more minute on trying to
figure out the same problem with any other regression test (which might
not even be as easily worked around as with a semi-simple --upload-pack
option).

Thank you for wanting to help. Please accept my apologies for expressing
in a poor way that I appreciate your eagerness to provide a patch, but
that I think nevertheless that it would be better to work on the GIT_TRACE
concurrency problem and its resolution via file locks. It would solve that
class of problems, instead of that single regression test being flakey.

Sorry,
Dscho