Re: [PATCHv3 5/5] t7406: fix call that was failing for the wrong reason
From: Junio C Hamano <hidden>
Date: 2018-08-07 17:37:16
Elijah Newren [off-list ref] writes:
A test making use of test_must_fail was failing like this: fatal: ambiguous argument '|': unknown revision or path not in the working tree. when the intent was to verify that a specific string was not found in the output of the git diff command, i.e. that grep returned non-zero. Fix the test to do that.
Nice. All other patches and the final shape of this script look sensible. Thanks.
quoted hunk
Signed-off-by: Elijah Newren <redacted> --- t/t7406-submodule-update.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh index 5b42bbe9fa..7dd1c86b02 100755 --- a/t/t7406-submodule-update.sh +++ b/t/t7406-submodule-update.sh@@ -603,7 +603,8 @@ test_expect_success 'submodule update - update=none in .git/config but --checkou git diff --name-only >out && grep submodule out && git submodule update --checkout && - test_must_fail git diff --name-only \| grep submodule && + git diff --name-only >out && + ! grep submodule out && (cd submodule && ! compare_head ) &&