Re: [PATCH v2] t4150: fix broken test for am --scissors

On Tue, Aug 7, 2018 at 1:42 AM, Andrei Rybak [off-list ref] wrote:

On 2018-08-06 10:58, Paul Tan wrote:

quoted

quoted

+       git commit -F msg-without-scissors-line &&
+       git tag scissors-used &&

Nit: I'm not quite sure about naming the tag "scissors-used" though,
since this commit was not created from the output of "git am
--scissors". Maybe it should be named `commit-without-scissors-line`
or something?

quoted

+       git commit -F msg-with-scissors-line &&
+       git tag scissors-not-used &&

Nit: Likewise, perhaps this tag could be named `commit-with-scissors-line`?

How about "expected-for-scissors" and "expected-for-no-scissors"?

Yep that's fine.

Thanks,
Paul