Re: [PATCH] add a script to diff rendered documentation
From: Eric Sunshine <hidden>
Date: 2018-08-03 21:33:31
On Fri, Aug 3, 2018 at 4:52 PM Jeff King [off-list ref] wrote:
quoted hunk ↗ jump to hunk
[...] Let's provide a script that builds and installs the manpages for two commits, renders the results using "man", and diffs the result. Since this is time-consuming, we'll also do our best to avoid repeated work, keeping intermediate results between runs. [...] Signed-off-by: Jeff King <redacted> ---diff --git a/Documentation/doc-diff b/Documentation/doc-diff@@ -0,0 +1,100 @@ +OPTIONS_SPEC="\ +doc-diff <from> <to> [-- diff options]
Should this be?
doc-diff [<options>] <from> <to> [-- <diff-options>]
+-- +j parallel argument to pass to make +f force rebuild; do not rely on cached results +"
Should "j" and "f" be "-j" and "-f", respectively?
+while test $# -gt 0
+do
+ case "$1" in
+ -j)
+ parallel=${1#-j} ;;
+ -f)
+ force=t ;;
+ --)
+ shift; break ;;
+ *)
+ usage ;;There doesn't seem to a usage() function defined anywhere (and OPTIONS_SPEC doesn't seem to be used).
+ esac + shift +done +# We'll do both builds in a single worktree, which lets make reuse +# results that don't differ between the two trees.
"which lets make reuse"?