Re: [PATCH v3 1/2] sequencer: handle errors in read_author_ident()

From
Junio C Hamano <hidden>
Date
2018-08-03 15:53:41
Eric Sunshine [off-list ref] writes:
I think this patch can be simplified considerably by shifting one's
perspective. If we admit that read_author_ident() is already correctly
reporting an error by returning NULL (which is exactly what it is
doing), then the bug is is purely on the calling side; namely, the
caller is ignoring the error. (In fact, your commit message already
states this.)
This approach looks quite sensible.
Thread (1 message) 1 message, 1 author, last reply 2018-08-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help