Re: [PATCH] sha1dc: update from upstream
From: Michael Felt (aixtools) <hidden>
Date: 2018-08-02 21:29:43
Possibly related (same subject, not in this thread)
- 2019-05-16 · Re: [PATCH] sha1dc: update from upstream · Osipov, Michael <hidden>
- 2019-05-16 · Re: [PATCH] sha1dc: update from upstream · Ævar Arnfjörð Bjarmason <hidden>
- 2019-05-16 · Re: [PATCH] sha1dc: update from upstream · Osipov, Michael <hidden>
- 2019-05-15 · Re: [PATCH] sha1dc: update from upstream · Ævar Arnfjörð Bjarmason <hidden>
- 2019-05-14 · Re: [PATCH] sha1dc: update from upstream · Osipov, Michael <hidden>
Sent from my iPhone
On 2 Aug 2018, at 22:50, Ævar Arnfjörð Bjarmason [off-list ref] wrote: Update sha1dc from the latest version by the upstream maintainer[1]. See 2db87328ef ("Merge branch 'ab/sha1dc'", 2017-07-10) for the last update. This fixes an issue where AIX was wrongly detected as a Little-endian instead of a Big-endian system. See [2][3][4]. 1. https://github.com/cr-marcstevens/sha1collisiondetection/commit/232357eb2ea0397388254a4b188333a227bf5b10 2. https://github.com/cr-marcstevens/sha1collisiondetection/pull/45 3. https://github.com/cr-marcstevens/sha1collisiondetection/pull/42 4. https://public-inbox.org/git/20180729200623.GF945730@genre.crustytoothpaste.net/ Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> ---quoted
On Wed, Aug 01 2018, Ævar Arnfjörð Bjarmason wrote: https://github.com/cr-marcstevens/sha1collisiondetection/pull/45 [...] It should work, but as noted in the MR please test it so we can make sure, and then (if you have a GitHub account) comment on the MR saying it works for you.This got merged upstream, and as noted in that upstream PR I've personally tested this on AIX under both GCC and IBM's xlc on the GCC compile farm, it works.
Thanks. I already have git 2.18 in use with the manual patch.
quoted hunk ↗ jump to hunk
sha1collisiondetection | 2 +- sha1dc/sha1.c | 12 +++++++++++- 2 files changed, 12 insertions(+), 2 deletions(-)diff --git a/sha1collisiondetection b/sha1collisiondetection index 19d97bf5af..232357eb2e 160000 --- a/sha1collisiondetection +++ b/sha1collisiondetection@@ -1 +1 @@ -Subproject commit 19d97bf5af05312267c2e874ee6bcf584d9e9681 +Subproject commit 232357eb2ea0397388254a4b188333a227bf5b10diff --git a/sha1dc/sha1.c b/sha1dc/sha1.c index 25eded1399..df0630bc6d 100644 --- a/sha1dc/sha1.c +++ b/sha1dc/sha1.c@@ -93,13 +93,23 @@#define SHA1DC_BIGENDIAN /* Not under GCC-alike or glibc or *BSD or newlib or <processor whitelist> */ +#elif (defined(_AIX)) + +/* + * Defines Big Endian on a whitelist of OSs that are known to be Big + * Endian-only. See + * https://public-inbox.org/git/93056823-2740-d072-1ebd-46b440b33d7e@felt.demon.nl/ + */ +#define SHA1DC_BIGENDIAN + +/* Not under GCC-alike or glibc or *BSD or newlib or <processor whitelist> or <os whitelist> */ #elif defined(SHA1DC_ON_INTEL_LIKE_PROCESSOR) /* * As a last resort before we do anything else we're not 100% sure * about below, we blacklist specific processors here. We could add * more, see e.g. https://wiki.debian.org/ArchitectureSpecificsMemo */ -#else /* Not under GCC-alike or glibc or *BSD or newlib or <processor whitelist> or <processor blacklist> */ +#else /* Not under GCC-alike or glibc or *BSD or newlib or <processor whitelist> or <os whitelist> or <processor blacklist> */ /* We do nothing more here for now */ /*#error "Uncomment this to see if you fall through all the detection"*/ -- 2.18.0.345.g5c9ce644c3