Re: [PATCH 1/2] config: document git config getter return value.
From: Eric Sunshine <hidden>
Date: 2018-08-02 17:19:14
On Thu, Aug 2, 2018 at 8:13 AM Han-Wen Nienhuys [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/config.h b/config.h@@ -178,10 +178,16 @@ struct config_set { extern void git_configset_init(struct config_set *cs); -extern int git_configset_add_file(struct config_set *cs, const char *filename); -extern int git_configset_get_value(struct config_set *cs, const char *key, const char **value); +/* + * These functions return 1 if not found, and 0 if found, leaving the found + * value in the 'dest' pointer. + */ +extern int git_configset_add_file(struct config_set *cs, const char *filename); +extern int git_configset_get_value(struct config_set *cs, const char *key, const char **dest); extern int git_configset_get_string_const(struct config_set *cs, const char *key, const char **dest); extern int git_configset_get_string(struct config_set *cs, const char *key, char **dest); extern int git_configset_get_int(struct config_set *cs, const char *key, int *dest);
It doesn't seem like git_configset_add_file() fits in this group. It's neither searching for something (thus won't return "found" / "not found"), nor is it returning 0 or 1. (It returns 0 on success and -1 on failure.)