Re: [PATCH 2/2] Highlight keywords in remote sideband output.

On Wed, Aug 1, 2018 at 8:17 PM Junio C Hamano [off-list ref] wrote:

quoted

quoted

Hmm, do we actually say things like "Error: blah"?  I am not sure if
I like this strncasecmp all that much.

this is for the remote end, so what we (git-core) says isn't all that
relevant.

It is very relevant, I would think.  Because the coloring is
controlled at the client end with this implementation, third-party
remote implementations have strong incentive to follow what our
remote end says and not to deviate.  Preventing them from being
different just to be different does help the users, no?

But the ship has already sailed: Gerrit has been saying "ERROR"
instead of "error" for many years. In the case of Gerrit, the upper
case message is a (poor) way to make the error message stand out from
the sea of progress messages that "git push" prints on the terminal,
without requiring a newer version of git-core.

--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado