Re: [PATCH v1] config.c: fix msvc compile error

On 7/24/2018 3:56 PM, Taylor Blau wrote:

On Tue, Jul 24, 2018 at 03:30:10PM +0000, git@jeffhostetler.com wrote:

quoted

From: Jeff Hostetler <redacted>

In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added
to builtin/config.c to define a new function and a forward declaration
for an array of unknown size.  This causes a compile error under MSVC.

Thanks for spending time fixing that. fb0dc3bac1 (builtin/config.c:
support `--type=<type>` as preferred alias for `--<type>`, 2018-04-18)
is from me, so I owe you an extra thanks for patching up mistakes :-).

As others have noted in this thread, another patch was sent into similar
effect, which has already been queued, and I agree that we should prefer
that, since it's further along.


Thanks,
Taylor

Yes, the other version is further along.  Let's take it.
Jeff