Re: [PATCH 03/14] format-patch: teach --interdiff to respect -v/--reroll-count
From: Duy Nguyen <hidden>
Date: 2018-07-23 16:12:42
On Sun, Jul 22, 2018 at 11:57 AM Eric Sunshine [off-list ref] wrote:
The --interdiff option introduces the embedded interdiff generically as "Interdiff:", however, we can do better when --reroll-count is specified
Oh boy. --reroll-count was added in 2012 and here I am typing --subject-prefix='PATCH vX' everyday, thinking that somebody should really do something about it. I've learned --reroll-count today!
quoted hunk ↗ jump to hunk
diff --git a/revision.h b/revision.h index 61931fbac5..ffeadc261a 100644 --- a/revision.h +++ b/revision.h@@ -215,6 +215,7 @@ struct rev_info { /* interdiff */ const struct object_id *idiff_oid1; const struct object_id *idiff_oid2; + const char *idiff_title;
I feel we're abusing struct rev_info a bit for this since this interdiff thing is very builtin/log.c's business and not at all related to rev walk. Is it possible (and easy) to just pass idfff_title from cmd_format_patch to make_cover_letter()? If it's a lot of code, then I guess we can just leave it here. -- Duy