Re: [PATCH v3 6/9] Use remote_odb_get_direct() and has_remote_odb()
From: Duy Nguyen <hidden>
Date: 2018-07-22 09:05:29
On Fri, Jul 13, 2018 at 7:50 PM Christian Couder [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -477,8 +478,8 @@ static int batch_objects(struct batch_options *opt) for_each_loose_object(batch_loose_object, &sa, 0); for_each_packed_object(batch_packed_object, &sa, 0); - if (repository_format_partial_clone) - warning("This repository has extensions.partialClone set. Some objects may not be loaded."); + if (has_remote_odb()) + warning("This repository uses an odb. Some objects may not be loaded.");
I can see the string is not marked for translation before, but since you're updating it, please consider _() if needed. Maybe also say "remote object database" instead of odb -- Duy