Re: [PATCH v4 2/7] t/t7510: check the validation of the new config gpg.format

Am Tue, 17 Jul 2018 14:31:56 -0700
schrieb Junio C Hamano [off-list ref]:

Henning Schild [off-list ref] writes:

quoted

Test setting gpg.format to both invalid and valid values.

Signed-off-by: Henning Schild <redacted>
---
 t/t7510-signed-commit.sh | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh
index 6e2015ed9..7bdad570c 100755
--- a/t/t7510-signed-commit.sh
+++ b/t/t7510-signed-commit.sh

@@ -227,4 +227,13 @@ test_expect_success GPG 'log.showsignature

behaves like --show-signature' ' grep "gpg: Good signature" actual
 '
 
+test_expect_success GPG 'check config gpg.format values' '
+	test_config gpg.format openpgp &&
+	git commit -S --amend -m "success" &&
+	test_config gpg.format OpEnPgP &&
+	test_must_fail git commit -S --amend -m "fail" &&  

This second one is a good demonstration that the value for this
variable is case sensitive.

quoted

+	test_config gpg.format malformed &&
+	test_must_fail git commit -S --amend -m "fail"  

And there is no longer a good reason to try another one.  Let's drop
this last/third case.

Done.

Henning

quoted

+'
+
 test_done