Thread (42 messages) flat view 42 messages, 3 authors, 2018-07-16

Re: [PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

From: Jeff King <hidden>
Date: 2018-07-16 21:35:14

On Sat, Jul 14, 2018 at 06:13:47PM +0000, brian m. carlson wrote:
On Tue, Jul 10, 2018 at 12:56:38PM -0400, Jeff King wrote:
quoted
On Tue, Jul 10, 2018 at 12:54:13PM -0400, Jeff King wrote:
quoted
Should we allow:

  [gpg "OpenPGP"]
  program = whatever

given that we allow:

  [gpg]
  format = OpenPGP

? I think just using strcasecmp() here would be sufficient. But I wonder
if it is a symptom of using the wrong tool (subsections) when we don't
need it.
I did just read the discussion in response to v1, where everybody told
you the opposite. ;)

So I guess my question/points are more for brian and Junio.
I'm okay with us forcing "openpgp".  That seems sane enough for now, and
if people scream loudly, we can loosen it.
Well, I specifically meant "are you sure subsections like this are a
good idea". But it seems like people think so?

If so, then I think the best route is just dictating that yes,
gpg.format is case-sensitive because it is referencing
gpg.<format>.program, which is itself case-sensitive (and "openpgp" is
the right spelling).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help