Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains

Eric Sunshine [off-list ref] writes:

On Thu, Jul 12, 2018 at 8:37 AM SZEDER Gábor [off-list ref] wrote:

quoted

The change below should be squashed into this patch to fix a
previously unnoticed broken &&-chain.  I think you missed it, because
this test script is rather expensive and you didn't run it with
GIT_TEST_CLONE_2GB=YesPlease.

diff --git a/t/t5608-clone-2gb.sh b/t/t5608-clone-2gb.sh

@@ -23,7 +23,7 @@ test_expect_success CLONE_2GB 'setup' '
-               echo "M 100644 :$i $i" >> commit
+               echo "M 100644 :$i $i" >> commit &&

Thanks for finding this. I tried to get as much coverage as possible
by installing packages I don't normally have installed (Apache, cvs,
cvsps, Subversion, Perforce, etc.) and even temporarily modified a
script or two to force it run ...

Thanks, both.  I think the &&-chain fix series is already large and
also otherwise seem to be pretty solid, so let's not reroll but
queue this addition on top.