Thread (1 message) 1 message, 1 author, 2018-07-10

Re: [GSoC][PATCH v3 05/13] sequencer: add a new function to silence a command, except if it fails

From: Junio C Hamano <hidden>
Date: 2018-07-10 18:19:21

Alban Gruin [off-list ref] writes:
This adds a new function, run_command_silent_on_success(), to
redirect the stdout and stderr of a command to a strbuf, and then to run
that command. This strbuf is printed only if the command fails. It is
functionnaly similar to output() from git-rebase.sh.

run_git_commit() is then refactored to use of
run_command_silent_on_success().

Signed-off-by: Alban Gruin <redacted>
---
 sequencer.c | 51 +++++++++++++++++++++++++--------------------------
 1 file changed, 25 insertions(+), 26 deletions(-)
Looks good to me; it seems to cover the glitches pointed out in the
previous round well.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help