Re: Git 2.18: RUNTIME_PREFIX... is it working?
flat view
From: Junio C Hamano <hidden>
Date: 2018-07-09 21:05:22
Jeff King [off-list ref] writes:
On Sun, Jul 08, 2018 at 11:52:22PM +0200, Johannes Schindelin wrote:quoted
Now, if you care to have a look at Dan's (and my) patches to implement RUNTIME_PREFIX so that it looks for a directory *relative to the Git binary*, you will see that it is far from portable. In fact, it is very definitely not portable, and needs specific support for *every single supported Operating System*. And while we covered a lot, we did not cover all of them. So unfortunately, it is impossible to make it the default, I am afraid.Would it be reasonable to make RUNTIME_PREFIX the default on systems where we _do_ have that support? AFAIK there is no downside to having it enabled (minus a few syscalls to find the prefix, I suppose, but I assume that's negligible). I.e., a patch to config.mak.uname (and possibly better support for _disabling_ it, though I think "make RUNTIME_PREFIX=" would probably work).
I think that is a sensible approach.