Thread (1 message) 1 message, 1 author, 2018-07-09

Re: [PATCH 2/2] t3430: update to test with custom commentChar

From: Junio C Hamano <hidden>
Date: 2018-07-09 20:06:03

Daniel Harding [off-list ref] writes:
One question about my original patch - there I had replaced a "grep
-v" call with a "git stripspace" call in the 'generate correct todo
list' test.  Is relying on "git stripspace" in a test acceptable, or
should external text manipulation tools like grep, sed etc. be
preferred?
I think trusting stripspace is OK here.  Even though this test is
not about stripspace (i.e. trying to catch breakage in stripspace),
if we broke it, we'll notice it as a side effect of running this
test ;-).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help