Re: [PATCH v3 18/20] completion: support `git range-diff`
From: Junio C Hamano <hidden>
Date: 2018-07-06 22:46:24
"Johannes Schindelin via GitGitGadget" [off-list ref] writes:
From: Johannes Schindelin <redacted> Tab completion of `git range-diff` is very convenient, especially given that the revision arguments to specify the commit ranges to compare are typically more complex than, say, your grandfather's `git log` arguments. Signed-off-by: Johannes Schindelin <redacted>
Have three-dash lines here, or perhaps have some validation hook in the garden-shears tool to notice these leftoer bits we see below?
quoted hunk
squash! WIP completion: support `git range-diff` Revert "WIP completion: support `git range-diff`" This reverts commit 2e7af652af9e53a19fd947f8ebe37a78043afa49. --- contrib/completion/git-completion.bash | 14 ++++++++++++++ 1 file changed, 14 insertions(+)diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 94c95516e..402490673 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash@@ -1976,6 +1976,20 @@ _git_push () __git_complete_remote_or_refspec } +_git_range_diff () +{ + case "$cur" in + --*) + __gitcomp " + --creation-factor= --dual-color + $__git_diff_common_options + " + return + ;; + esac + __git_complete_revlist +} + _git_rebase () { __git_find_repo_path