Re: [PATCH 3/5] rebase: refactor common shell functions into their own file

On Thu, Jun 28, 2018 at 12:48 AM Pratik Karki [off-list ref] wrote:

The function present in `git-legacy-rebase.sh` are used by backends
so, this refactor tries to extract the functions out so that, the

it not only tries to, it actually does. :)

`git-legacy-rebase.sh` can be retired easily as the
`git-rebase--common.sh` will provide the functions for now.

The motivation behind this is to call the backend functions
*directly* from C, bypassing `git-rebase.sh`. Therefore those functions
need to live in a separate file: we need to be able to call
`.git-rebase--common` in that script snippet so that those functions
are defined.

Makes sense.

I applied the patch (and checked the move via the --color-moved option
to see if there are discrepancies that slip in easily via rebases as there is
more work currently going on in the rebase area) and the found the functions
were moved as-is, just reordered. Can you give a hint on why you choose a
different order for the moved functions (not as an email reply, but as part
of the commit message, later on people may ask the same question only
to find this commit via git-blame or git-log for example)

Thanks,
Stefan