Re: [PATCH v6 0/4] stash: add new tests and introduce a new helper function

Johannes Schindelin [off-list ref] writes:

Hi,

On Mon, 25 Jun 2018, Paul-Sebastian Ungureanu wrote:

quoted

This first series of patches does bring some changes and improvements to
the test suite. One of the patches also introduces a new function
`get_oidf()` which will be hepful for the incoming patches related to
`git stash`.

For reviewers: it is *my* fault that this patch submission is a bit funny
with two 1/4 and one 1/6 patches... *I* suggested to not send a 14-strong
patch series but split it into three, and then I failed to explain the
correct invocation to do that from the command-line.

My sincere apologies,
Dscho

Heh, what is more useful than apology is to tell us which order
these three (apparent) series build on top of each other ;-)

The answer, IIUC, is that 

 * oidf+tests come first, then
 * apply/drop/branch/pop (as these rely on oidf) on top, and finally
 * list (as it wants to add to stash--helper that is a new file in the middle)

When there is clear dependency like that, I agree that it would help
readers to emphasize that these cannot be applied in an arbitrary
order.  It is especially true as the second part of the above _will_
apply more-or-less cleanly without the first one, and then fail to
compile due to lack of oidf.

Thanks.