Re: [PATCH v2 1/2] t3418: add testcase showing problems with rebase -i and strategy options

On Wed, Jun 27, 2018 at 9:54 AM, Junio C Hamano [off-list ref] wrote:

+       (
+               PATH=./test-bin:$PATH
+               test_must_fail git rebase -i -s funny -Xopt -Xfoo master topic
+       ) &&

+       (
+               PATH=./test-bin:$PATH
+               git rebase --continue
+       ) &&

and it would be reasonable to assume that these variable assignments
would not fail.  IOW, there is no BUG in breaking &&-chain at these
two places.  It is merely that the automated mechanism introduced by
step 29/29 of that other series does not understand that (which is
expected).  It is not wrong to have && at the end of the assignment,
though.

Having said that, it would be simpler for at least the latter to
write it using a single-shot environment assignment, perhaps?  I.e.

        PATH=./test-bin:$PATH git rebase --continue &&

without running in a subshell?

Seems reasonable.  Since these tests were essentially copies of other
tests within the same file, just for rebase -i instead of -m, should I
also add another patch to the series fixing up the rebase -m testcase
to also replace the subshell with a single-shot environment
assignment?