Thread (1 message) 1 message, 1 author, 2018-06-26

Re: [PATCH v3 0/7] grep.c: teach --column to 'git-grep(1)'

From: Junio C Hamano <hidden>
Date: 2018-06-26 16:46:04

Taylor Blau [off-list ref] writes:
On Mon, Jun 25, 2018 at 02:43:50PM -0400, Jeff King wrote:
quoted
On Fri, Jun 22, 2018 at 10:49:26AM -0500, Taylor Blau wrote:
quoted
Since the last time, only a couple of things have changed at Peff's
suggestions in [1]. The changes are summarized here, and an inter-diff
is available below:

  - Change "%zu" to PRIuMAX (and an appropriate cast into uintmax_t). I
    plan to send a follow-up patch to convert this back to "%zu" to see
    how people feel about it, but I wanted to keep that out of the
    present series in order to not hold things up.
...
Jinxes aside, this interdiff looks good to me.
Thanks; I hope that I haven't jinxed anything :-).

I'm going to avoid sending the PRIuMAX -> "%zu" patch, since dscho
points out that it's not available on Windows [1].
OK, so what I queued on 'pu' seems to be ready to advance, which is
good.  Keeping topics in flight on 'pu', unable to convince myself
that they are ready to advance to 'next', makes me feel uneasy and
unhappy, and having to worry about one less such topic is a good
news ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help