Re: [PATCH] Makefile: tweak sed invocation
From: Eric Sunshine <hidden>
Date: 2018-06-25 20:15:43
On Mon, Jun 25, 2018 at 3:18 PM Alejandro R. Sedeño [off-list ref] wrote:
With GNU sed, the r command doesn't care if a space separates it and the filename it reads from. With SunOS sed, the space is required.
MacOS and the various BSD's ship with BSD 'sed', not GNU 'sed', so it seemed prudent to check this change against them as well, which I did, and can report that it does not cause any regression on those platforms. Therefore, the patch looks good. Thanks.
quoted hunk ↗ jump to hunk
Signed-off-by: Alejandro R. Sedeño <redacted> ---diff --git a/Makefile b/Makefile@@ -2109,7 +2109,7 @@ $(SCRIPT_PERL_GEN): % : %.perl GIT-PERL-DEFINES GIT-PERL-HEADER GIT-VERSION-FILE $(QUIET_GEN)$(RM) $@ $@+ && \ sed -e '1{' \ -e ' s|#!.*perl|#!$(PERL_PATH_SQ)|' \ - -e ' rGIT-PERL-HEADER' \ + -e ' r GIT-PERL-HEADER' \ -e ' G' \ -e '}' \ -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \