Re: [PATCH v2 07/24] multi-pack-index: expand test data
From: Junio C Hamano <hidden>
Date: 2018-06-25 19:46:01
Derrick Stolee [off-list ref] writes:
test_expect_success 'write midx with no packs' ' + test_when_finished rm pack/multi-pack-index &&
It is generally a good idea to give "-f" to "rm" used in test_when_finished. The main command sequence may have failed before it has a chance to create that file; even though an error will be ignored by the when_finished handler, it is a good code hygiene to mark expected condition (e.g. the file to be removed may not exist at this point) to signal to future readers that the author knew what s/he was writing.
quoted hunk
git multi-pack-index --object-dir=. write && test_path_is_file pack/multi-pack-index && midx_read_expect ' +test_expect_success 'create objects' ' + for i in `test_seq 1 5`
Please write it as "$(test_seq 1 5)"
quoted hunk
+ do + iii=$(printf '%03i' $i) + test-tool genrandom "bar" 200 > wide_delta_$iii &&
test-tool genrandom "bar" 200 >"wide_delta_$iii" && i.e. no SP between the redirection operator and the target file name. Also dq around target file name that depends on variable substitution to tell bash that we know what we are doing (some vintage of bash will throw warning at us unless we do so).