Re: [PATCH] branch: issue "-l" deprecation warning after pager starts

On Sat, Jun 02, 2018 at 06:46:31AM +0200, Duy Nguyen wrote:

quoted

        if (used_deprecated_reflog_option) {
-               warning("the '-l' alias for '--create-reflog' is deprecated;");
-               warning("it will be removed in a future version of Git");
+               if (list) {
+                       warning("the '-l' option is an alias for '--create-reflog' and");
+                       warning("has no effect in list mode. This option will soon be");
+                       warning("removed and you should omit it (or use '--list' instead).");
+               } else {
+                       warning("the '-l' alias for '--create-reflog' is deprecated;");
+                       warning("it will be removed in a future version of Git");
+               }

This is already in 'next', but could you do a follow up patch to mark
these strings for translation? While at there, concatenating them into
full sentences would also help translators.

Already being discussed elsewhere on the thread; we're hoping for a
warning() that will auto-prefix each one.

That said, I think I'm going to re-roll this in the direction discussed
elsewhere in the thread (skipping the warning for list-mode).

-Peff