Thread (6 messages) 6 messages, 2 authors, 2018-06-01

Re: [PATCH v2] sequencer: ensure labels that are object IDs are rewritten

From: Johannes Schindelin <hidden>
Date: 2018-06-01 19:02:18

Hi Brian,

On Fri, 1 Jun 2018, brian m. carlson wrote:
When writing the todo script for --rebase-merges, we try to find a label
for certain commits.  If the label ends up being a valid object ID, such
as when we merge a detached commit, we want to rewrite it so it is no
longer a valid object ID.

However, the code path that does this checks for its length to be
equivalent to GIT_SHA1_RAWSZ, which isn't correct, since what we are
reading is a hex object ID.  Instead, check for the length being
equivalent to that of a hex object ID.  Use the_hash_algo so this code
works regardless of the hash size.

Signed-off-by: brian m. carlson <redacted>
ACK!
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help