Thread (4 messages) flat view 4 messages, 3 authors, 2018-06-20

Re: [PATCH v3 0/7] allocate cache entries from memory pool

From: Junio C Hamano <hidden>
Date: 2018-05-24 04:55:23

Jameson Miller [off-list ref] writes:
Changes from V2:

	- Tweak logic of finding available memory block for memory
          allocation
	
	  - Only search head block
Hmph.  Is that because we generally do not free() a lot so once a
block is filled, there is not much chance that we have reclaimed
space in the block later?
	- Tweaked handling of large memory allocations.
	
	  - Large blocks now tracked in same manner as "regular"
            blocks
	  
	  - Large blocks are placed at end of linked list of memory
            blocks
If we are only carving out of the most recently allocated block, it
seems that there is no point looking for "the end", no?

	- Cache_entry type gains notion of whether it was allocated
          from memory pool or not
	
	  - Collapsed cache_entry discard logic into single
            function. This should make code easier to maintain
That certainly should be safer to have a back-pointer pointing to
which pool each entry came from, but doesn't it result in memory
bloat?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help