Re: [PATCH v2 10/12] commit-graph: add '--reachable' option
From: Martin Ågren <hidden>
Date: 2018-05-17 18:16:26
On 11 May 2018 at 23:15, Derrick Stolee [off-list ref] wrote:
quoted hunk ↗ jump to hunk
When writing commit-graph files, it can be convenient to ask for all reachable commits (starting at the ref set) in the resulting file. This is particularly helpful when writing to stdin is complicated, such as a future integration with 'git gc' which will call 'git commit-graph write --reachable' after performing cleanup of the object database. Signed-off-by: Derrick Stolee <redacted> --- Documentation/git-commit-graph.txt | 8 ++++++-- builtin/commit-graph.c | 41 ++++++++++++++++++++++++++++++++++---- 2 files changed, 43 insertions(+), 6 deletions(-)diff --git a/Documentation/git-commit-graph.txt b/Documentation/git-commit-graph.txt index a222cfab08..cc1715a823 100644 --- a/Documentation/git-commit-graph.txt +++ b/Documentation/git-commit-graph.txt@@ -38,12 +38,16 @@ Write a commit graph file based on the commits found in packfiles. + With the `--stdin-packs` option, generate the new commit graph by walking objects only in the specified pack-indexes. (Cannot be combined -with --stdin-commits.) +with --stdin-commits or --reachable.)
You could enclose --reachable in `...` for nicer rendering and fix --stdin-commits as well while you're here.
With the `--stdin-commits` option, generate the new commit graph by walking commits starting at the commits specified in stdin as a list of OIDs in hex, one OID per line. (Cannot be combined with ---stdin-packs.) +--stdin-packs or --reachable.)
Ditto.
+With the `--reachable` option, generate the new commit graph by walking +commits starting at all refs. (Cannot be combined with --stdin-commits +or --stind-packs.)
Ditto. Also, s/stind/stdin/. Martin