Thread (2 messages) flat view 2 messages, 2 authors, 2018-05-19

Re: [PATCH v2 11/14] show-branch: use commit-slab for commit-name instead of commit->util

From: Junio C Hamano <hidden>
Date: 2018-05-14 06:45:37

Nguyễn Thái Ngọc Duy  [off-list ref] writes:
It's done so that commit->util can be removed. See more explanation in
the commit that removes commit->util.

Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
---
 builtin/show-branch.c | 39 +++++++++++++++++++++++++++------------
 1 file changed, 27 insertions(+), 12 deletions(-)
Looks obviously correct.  

Another place we could use commit-slab in this program, which I
think is a more interesting application, is to use it to store a
bitmask with runtime-computed width to replace those object->flags
bits, which will allow us to lift the MAX_REVS limitation.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help