Thread (1 message) 1 message, 1 author, 2018-05-13

Re: [PATCH v2 04/14] describe: use commit-slab for commit names instead of commit->util

From: Junio C Hamano <hidden>
Date: 2018-05-13 23:45:15

Nguyễn Thái Ngọc Duy  [off-list ref] writes:
+		slot = commit_names_peek(&commit_names, c);
+		n = slot ? *slot : NULL;
Seeing this and the helper in the previous step makes me wonder if
we also want a "peek-and-then-peel" variant that encapsulates this
pattern.  We'll know when we read the series through.

So far looking good.  Thanks.
 		if (n) {
 			if (!tags && !all && n->prio < 2) {
 				unannotated_cnt++;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help