On Mon, Apr 30, 2018 at 09:53:33PM -0400, Eric Sunshine wrote:

On Mon, Apr 30, 2018 at 8:02 PM, brian m. carlson
[off-list ref] wrote:

quoted

When formatting a series of patches using --attach and --cover-letter,
the cover letter lacks the closing MIME boundary, violating RFC 2046.
Certain clients, such as Thunderbird, discard the message body in such a
case.

Since the cover letter is just one part and sending it as
multipart/mixed is not very useful, always emit it as text/plain,
avoiding the boundary problem altogether.

Reported-by: Patrick Hemmer <redacted>
Signed-off-by: brian m. carlson <redacted>
---

diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh

@@ -1661,6 +1661,15 @@ test_expect_success 'format-patch --base with --attach' '
+test_expect_success 'format-patch --attach cover-letter only is non-multipart' '
+       test_when_finished "rm -r patches" &&
+       git format-patch -o patches --cover-letter --attach=mimemime --base=HEAD~ -1 &&

Nit: "rm -rf" would be a bit more robust against git-format-patch
somehow crashing before creating the "patches" directory.

Sure, I can reroll with that change.  I had considered doing that, but
decided against it.  I hadn't thought of resilience against a failed git
format-patch, though.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204