Re: [PATCH v1 1/1] test: Correct detection of UTF8_NFD_TO_NFC for APFS
From: Elijah Newren <hidden>
Date: 2018-04-30 15:48:00
On Mon, Apr 30, 2018 at 8:41 AM, Torsten Bögershausen [off-list ref] wrote:
On 30.04.18 17:33, Elijah Newren wrote:quoted
On Sun, Apr 29, 2018 at 11:35 PM, [off-list ref] wrote:quoted
From: Torsten Bögershausen <redacted>
quoted
quoted
@@ -1106,12 +1106,7 @@ test_lazy_prereq UTF8_NFD_TO_NFC 'I'm not sure what "NFD" and "NFC" stand for, but I suspect the test prerequisite name may be specific to how HFS handled things. If so, should it be renamed from UTF8_NFD_TO_NFC to something else, such as UTF8_NORMALIZATION?NFD and NFC both come from the unicode standard, and are just taken "as is" into the Git world: https://en.wikipedia.org/wiki/Unicode_equivalence If you are otherwise happy with the patch, would it be possible to run it on your system ? (I don't have a High Sierra box, but I am confident that the test work for you).
Sure, feel free to add a Tested-by: Elijah Newren <redacted> if you like. (Works with both 'test -r', as in your patch, and 'test -f', as suggested by Junio.)